Add ModalProvider(ContainerProvider)#821
Conversation
|
Thanks for the PR. I'm down with the direction but I think this should first align with the provider-neutral cloud sandbox shape from #793. Core asks:
Also, it would be nice to bring a simple example of inference with the modal sandbox, we can then build a training example from it. |
a379786 to
f02ec38
Compare
|
@joyliu-q From a high level, it looks good. Just missing the example. Could you update the PR description and/or add a simple example to the |
f02ec38 to
937ff75
Compare
sergiopaniego
left a comment
There was a problem hiding this comment.
I've created a PR for making the docs for containers consistent (#868), it'd be cool to improve the documentation on this PR aligning it with that PR 😄
|
@sergiopaniego would you be able to do that after merging your PR? I see your PR is currently open and it makes more sense to merge this one and then add doc consistency changes to the other PR. |
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
sergiopaniego
left a comment
There was a problem hiding this comment.
lgtm, thanks!! 🙌 raised #875 as a follow up
Summary
Sample PR of adding Modal as a container provider to OpenEnv.
Type of Change
Alignment Checklist
Before submitting, verify:
.claude/docs/PRINCIPLES.mdand this PR aligns with our principles.claude/docs/INVARIANTS.mdand no invariants are violated/pre-submit-pr(orbash .claude/hooks/lint.shand tests) and addressed all issuesRFC Status
Test Plan
Claude Code Review
Usage
Run it (from the repo root, src + envs on the path, with modal available):